Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @mui/styles as peerDependency #1820

Closed
thefat32 opened this issue Nov 29, 2021 · 5 comments
Closed

Add @mui/styles as peerDependency #1820

thefat32 opened this issue Nov 29, 2021 · 5 comments

Comments

@thefat32
Copy link

With the migration to MUI V5 it was necessary to use @mui/styles package to keep using createStyles and makeStyles utils. It should be added as a peerDependency.

@maganezf
Copy link

maganezf commented Dec 7, 2021

#1826 UP

@jalaluddin94
Copy link

I was just facing this issue too bcause MUI is upgrading, so I need to install @mui/styles package too. But when I check using
npm list mui-datatables
there is no peerDependency to @mui/styles.

@msd026
Copy link

msd026 commented Feb 3, 2022

This should not be a correct fix. @mui/styles is deprecated and is creating issues with the newer version of react.

TypeError: Cannot read property 'down' of undefined
at defaultTableStyles (/path-from-root/node_modules/mui-datatables/dist/index.js:246:2212)

@Fullbusters
Copy link
Contributor

@thefat32 in release 4.1.0 @mui/styles was removed at all from project, please update your version, and close issue if all is good now

@thefat32
Copy link
Author

As @Fullbusters pointed, this was solved in #1862. Thank you!

Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants