Is there a plan of migration to material-ui v5? #1513

yaminyaylo · 2020-09-11T14:14:00Z

The issue is when I updated the Material-UI library to the latest version I found out that MUI-datatables doesn't support the Material-UI library v5.

Updated Material-UI libs to the following versions:

"@material-ui/core": "5.0.0-alpha.9",
"@material-ui/icons": "5.0.0-alpha.7",
"@material-ui/lab": "5.0.0-alpha.9",
"@material-ui/pickers": "^4.0.0-alpha.12",
"@material-ui/styles": "5.0.0-alpha.8",

Expected Behavior

No errors and crashed on the Table filter action.

Current Behavior

There are errors and crashed on the Table filter action press.

I guess this issue is due to Material-UI library new version - The onE* transition props were removed. Use TransitionProps instead. https://github.com/mui-org/material-ui/releases/tag/v5.0.0-alpha.7

Steps to Reproduce (for bugs)

update material-ui and it's dependant libs to the latest
fix all breaking changes in your app
go to the page you have a table based on MUI-datatables
suppose it has passed data inside the table and filter option is true
click on the Filter icon button

Your Environment

Tech	Version
Material-UI	5.0.0-alpha.9
MUI-datatables	3.4.1
React	16.13.1
browser	Chrome (latest)
etc

patorjk · 2020-09-11T14:46:36Z

I would accept pull requests to get the table working on version 5. If it requires breaking changes, it'd require a version bump and would probably be worth waiting until the official version 5 is released. I have not yet used version 5.

Also worth mentioning: The Material UI team is actually going to release an official data-table component for version 5.0. I talked with the lead Material UI dev a few months ago about it, and chatted back and forth through email around 6-7 weeks ago with the developer they have working on the official data-table (I tried the table out and then made a bunch of suggestions - the table looks pretty good and the developer seemed very receptive to my feedback). The goal is to get rid of the need for 3rd party data-tables like mui-datatables and material-table. However, the unfortunate thing is that many of the features that mui-datatables currently supports will be locked behind a paid enterprise version (at least that was the case 6-7 weeks ago), so I'm assuming there will still a place for mui-datatables and material-table, but I've sort of taken a wait-and-see approach by not doing too much development, as I'm not sure what direction the community will go. However, I'm open to PRs from other devs.

yaminyaylo · 2020-09-16T12:10:40Z

@patorjk thanks a lot for a very quick response and explanation.

I will think about what to do next.

oliviertassinari · 2021-03-10T16:00:25Z

To add to @patorjk's message, it would be great that the library upgrades to @material-ui/core v5. From a high-level point of view, we are pushing in the following directions:

Material-UI core, which is meant to empower design systems. Completly MIT. We are currently expanding by polishing the core to the extreme, a11y, bugs, features, customization, documentation. We currently have a default Material Design theme and soon we will provide a second theme, more aligned with the latest design trends. We monetize with the designers, through paid design kits (Figma, Adobe XD, Sketch) and probably more tools in the future, advertising and premium templates.
Material-UI X, which is meant to provide advanced components, combo box, date picker, tree view, data grid, scheduler, charts, etc. We can't sustain all this effort without having some part of it paid. We employs three different tradeoffs there:
- MIT. For features that the community can sustain. It's for when there are enough contributions and the problem are simple enough. This work for instance, for the date picker (a bit borderline in terms of complexity, but we also have to give back).
- Pro (inexpensive). For when there might be open-source alternatives but nowhere need the level of polish we aim for. For instance, the xgrid might have paid features that https://github.com/adazzle/react-data-grid have free. Having alternatives like https://github.com/gregnb/mui-datatables or https://github.com/mbrn/material-table is actually healthy for the ecosystem.
- Premium. For what you would usually get in the most advanced premium UI libraries, ag-Grid, highcharts, Kendo-UI. We don't expect any open-source solutions to come near before a decade.

patorjk · 2021-03-10T19:12:17Z

@wdh2100 has taken over as the main maintainer. I wouldn't mind helping out though if he needs some assistance with this.

davidcraddock · 2021-03-10T23:25:48Z

so will this project be updated to v5?

wdh2100 · 2021-03-11T03:09:28Z

@davidcraddock

Yes, I hava plan to proceed.
When material-ui enter the stable phase, I will switch to v5.

https://github.com/gregnb/mui-datatables/issues?q=is%3Aissue+label%3A%22material+ui+5.0%22+

davidcraddock · 2021-03-11T04:15:29Z

@wdh2100 thanks for the clarification

yaminyaylo · 2021-03-17T11:18:55Z

@wdh2100 that's great news, looking forward to material-UI v.5 entering the stable phase

artivilla · 2021-07-01T19:00:20Z

Given material-ui release v5.0.0-beta.0 now encourages new projects to start with v5 I think it would be beneficial to support v5. Thoughts?

narkai · 2021-07-23T13:55:20Z

We really need this, because of all the changes in Material it does not make sense to start a project with the V4 anymore...

narkai · 2021-08-05T09:38:13Z

After days of struggling with Material v5 Datagrid component, I rolled back to Material v4 & mui-datatables.

Comparing the two libraries really showed how mui-datatables is relevant, it's just so good !

Even though Datagrid seems to go in the right direction, IMO it's still far behind in term of capabilities & developer experience (especially custom filtering / sorting).

yaminyaylo · 2021-08-05T10:49:59Z

yeah, all our codebase is waiting for migration of mui-datatables to material-ui v5 beta (actually we now using "5.0.0-alpha.5"), but mui-datatables is broken after increasing the version of the material-ui core higher than "5.0.0-alpha.5" :(

davidcraddock · 2021-08-05T10:53:55Z

Yeah I had to update my forked repository above to use the latest beta.2 material-ui today until there’s an official release

MendelBak · 2021-08-11T11:39:11Z

@yaminyaylo Is this library still maintained? I noticed there hasn't been many PRs or issues closed in the past few months. Is this because you're waiting till v5 of MUI comes out, and to migrate mui-datables to that, before allowing changes?

yaminyaylo · 2021-08-17T15:36:17Z

@yaminyaylo Is this library still maintained? I noticed there hasn't been many PRs or issues closed in the past few months. Is this because you're waiting till v5 of MUI comes out, and to migrate mui-datables to that, before allowing changes?

@MendelBak I hope it is still maintained because it will be a sad story :)
I'm waiting that mui-datatables devs will use material-ui v5 inside mui-datatables.

wdh2100 · 2021-08-18T08:39:05Z

@wdh2100 thanks for the clarification

@davidcraddock @lapico @yaminyaylo @MendelBak

I'll try to make an beta version

The target version is @material-ui/core@5.0.0-beta.4

Given material-ui release v5.0.0-beta.0 now encourages new projects to start with v5 I think it would be beneficial to support v5. Thoughts?

@artivilla

thanks!

luluhoc · 2021-08-27T23:17:23Z

Yeah I updated my app to v5 material just to find issue with mui-datatables :( please update it.

gnowland · 2021-08-28T07:22:17Z

@wdh2100 looks like v5 stable is two weeks away, will this be ready?

zxhmike · 2021-09-01T20:18:25Z

Hi @wdh2100 ,

Our team spent some time upgrading mui-datatables to Material-UI 5. The preliminary PR can be found here: #1772

Sorry, I just saw the updates on this issue that you were making some effort to do a similar upgrade. Hopefully, we did not step on your toes.

Please review the PR and give us feedback. We are able to bring up the examples page, but there are some known issues that we are looking into, which can be found in the description of the PR.

Thank you! Looking forward to your reply.

yaminyaylo · 2021-09-20T21:48:13Z

@davidcraddock

Yes, I hava plan to proceed.
When material-ui enter the stable phase, I will switch to v5.

https://github.com/gregnb/mui-datatables/issues?q=is%3Aissue+label%3A%22material+ui+5.0%22+

https://github.com/mui-org/material-ui/releases/tag/v5.0.0
material-ui recently has released v5, do you think we can expect mui-datatables to work on migrating to material-ui core latest?

293nav · 2021-10-01T11:45:11Z

Any update on upgrading this library to support mui v5. Material-ui has released a new stable version. I noticed that in the stable version the imports are now made from @mui/material instead of @material-ui/

3BDO-debug · 2021-10-15T10:59:44Z

I got it working with material ui v5 successfully by fixing some dependencies and little tweaks check it out now.

https://github.com/3BDO-debug/MUIDataTable-MUI-V5

yaminyaylo · 2021-12-07T12:17:31Z

Huge thanks to the team who migrated to material UI v5! You ROCK!!!

Can someone close the issue?

CC @patorjk @wdh2100

oliviertassinari mentioned this issue Mar 10, 2021

createMuiTheme v5 unable to extend the list of components mui/material-ui#25292

Closed

wdh2100 added the material ui 5.0 label Mar 11, 2021

yaminyaylo mentioned this issue Oct 1, 2021

Support MUI 5 #1785

Open

gnowland mentioned this issue Oct 18, 2021

Upgrade to Material-UI 5 #1772

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Is there a plan of migration to material-ui v5? #1513

Is there a plan of migration to material-ui v5? #1513

yaminyaylo commented Sep 11, 2020 •

edited

patorjk commented Sep 11, 2020

yaminyaylo commented Sep 16, 2020 •

edited

oliviertassinari commented Mar 10, 2021 •

edited

patorjk commented Mar 10, 2021

davidcraddock commented Mar 10, 2021

wdh2100 commented Mar 11, 2021

davidcraddock commented Mar 11, 2021

yaminyaylo commented Mar 17, 2021

artivilla commented Jul 1, 2021

narkai commented Jul 23, 2021 •

edited

narkai commented Aug 5, 2021 •

edited

yaminyaylo commented Aug 5, 2021 •

edited

davidcraddock commented Aug 5, 2021

MendelBak commented Aug 11, 2021

yaminyaylo commented Aug 17, 2021 •

edited

wdh2100 commented Aug 18, 2021

luluhoc commented Aug 27, 2021

gnowland commented Aug 28, 2021

zxhmike commented Sep 1, 2021 •

edited

yaminyaylo commented Sep 20, 2021 •

edited

293nav commented Oct 1, 2021

3BDO-debug commented Oct 15, 2021

yaminyaylo commented Dec 7, 2021

Is there a plan of migration to material-ui v5? #1513

Is there a plan of migration to material-ui v5? #1513

Comments

yaminyaylo commented Sep 11, 2020 • edited

Expected Behavior

Current Behavior

Steps to Reproduce (for bugs)

Your Environment

patorjk commented Sep 11, 2020

yaminyaylo commented Sep 16, 2020 • edited

oliviertassinari commented Mar 10, 2021 • edited

patorjk commented Mar 10, 2021

davidcraddock commented Mar 10, 2021

wdh2100 commented Mar 11, 2021

davidcraddock commented Mar 11, 2021

yaminyaylo commented Mar 17, 2021

artivilla commented Jul 1, 2021

narkai commented Jul 23, 2021 • edited

narkai commented Aug 5, 2021 • edited

yaminyaylo commented Aug 5, 2021 • edited

davidcraddock commented Aug 5, 2021

MendelBak commented Aug 11, 2021

yaminyaylo commented Aug 17, 2021 • edited

wdh2100 commented Aug 18, 2021

luluhoc commented Aug 27, 2021

gnowland commented Aug 28, 2021

zxhmike commented Sep 1, 2021 • edited

yaminyaylo commented Sep 20, 2021 • edited

293nav commented Oct 1, 2021

3BDO-debug commented Oct 15, 2021

yaminyaylo commented Dec 7, 2021

yaminyaylo commented Sep 11, 2020 •

edited

yaminyaylo commented Sep 16, 2020 •

edited

oliviertassinari commented Mar 10, 2021 •

edited

narkai commented Jul 23, 2021 •

edited

narkai commented Aug 5, 2021 •

edited

yaminyaylo commented Aug 5, 2021 •

edited

yaminyaylo commented Aug 17, 2021 •

edited

zxhmike commented Sep 1, 2021 •

edited

yaminyaylo commented Sep 20, 2021 •

edited