Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 5 support #67

Closed
fwh1990 opened this issue Oct 14, 2020 · 7 comments
Closed

Webpack 5 support #67

fwh1990 opened this issue Oct 14, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@fwh1990
Copy link

fwh1990 commented Oct 14, 2020

As we know wepback@5 had been published some days ago, I hope that you can update error-overlay-webpack-plugin to compatible with latest webpack, thank you

@gregberge gregberge added the enhancement New feature or request label Oct 28, 2020
@gregberge gregberge changed the title Update peerDependencies Webpack 5 support Oct 28, 2020
@gregberge
Copy link
Owner

Not a surprise! I will not fix it on my own, if someone is interested, feel free to submit a PR.

@JamesGelok
Copy link

help wanted tag should be on this issue

@chang-ke
Copy link
Contributor

chang-ke commented Dec 1, 2020

it depends on react-dev-utils...but react-dev-utils not support webpack5 till now. see facebook/create-react-app#9994

@dlimx
Copy link

dlimx commented Jan 17, 2021

react-dev-utils has removed it here facebook/create-react-app#10198, waiting on release now

@Mitsunee
Copy link

for whatever it's worth I just went ahead and installed error-overlay-webpack-plugin in a local repo and it appears to be working fine there despite the warning yarn showed upon installing. If chalk getting introduced into the browser by a dependency was the only problem this seems to be fixed now.

chang-ke pushed a commit to chang-ke/error-overlay-webpack-plugin that referenced this issue Apr 12, 2021
chang-ke pushed a commit to chang-ke/error-overlay-webpack-plugin that referenced this issue Apr 12, 2021
chang-ke pushed a commit to chang-ke/error-overlay-webpack-plugin that referenced this issue Apr 12, 2021
@chang-ke
Copy link
Contributor

chang-ke commented Apr 14, 2021

Not a surprise! I will not fix it on my own, if someone is interested, feel free to submit a PR.

Now I submit a PR #72

gregberge pushed a commit that referenced this issue Aug 30, 2021
Co-authored-by: dengbin03 <dengbin03@kuaishou.com>
@gregberge
Copy link
Owner

Fixed in v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants