Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to publish new version #560

Open
vmatyus opened this issue Mar 25, 2024 · 7 comments
Open

Request to publish new version #560

vmatyus opened this issue Mar 25, 2024 · 7 comments

Comments

@vmatyus
Copy link

vmatyus commented Mar 25, 2024

Dependency check reported CVE-2024-21503 in black, this way it is suggested to update to use version 24.3.0.

I see the update already was made on the main branch thanks to dependabot.

I would like to request a new release from this package, because there is a need for the vulnerability fix in our project.

@vmatyus
Copy link
Author

vmatyus commented Mar 25, 2024

Turned out there is no need for a new release here.
Thanks for your work.

@vmatyus
Copy link
Author

vmatyus commented Apr 8, 2024

Based on the answer from Dependency Check's support team, they suggest to release a new version from autohooks-plugin-black which uses at least black 24.3.0
See their response.

@aikebah
Copy link

aikebah commented Apr 8, 2024

A new release is not what I suggested, though it would solve the false positive that occurs right now.

@vmatyus
Copy link
Author

vmatyus commented Apr 8, 2024

@aikebah Would you share your point of view regarding what other options are available as a solution? Could you elaborate it more?

@aikebah
Copy link

aikebah commented Apr 8, 2024

The regular way for open source projects in case of a false positive (something that is almost unavoidable due to how ODC links software to CPEs which are the key to 'known vulnerabilities' with the NIST NVD data) is to file a 'False-positive Report' type issue with the project, which typically leads to a suppression added into the scanner after a triage of the report.

For python they typically take a bit longer to process as one of the maintainers needs to build and test the suppression. Other language ecosystems have an automatic suppression generation that allows a low-effort triage and approval by one of the project maintainers to be automatically added by the automation to the suppressions.

So the recommended course of action is to open your dependencycheck report (to be able to copy some values over that are asked for in the false positive report) and use the information within to open a new issue of type 'False Positive report' in the DependencyCheck project.

With the information requested in that form the DependencyCheck we would be able to create an appropriate rule within the hosted suppressions file so that the autohooks plugin is no longer detected as black itself (while still checking the transitive black dependency (which is already at a fixed version as you indicated in your question ticket)

@vmatyus
Copy link
Author

vmatyus commented Apr 9, 2024

@aikebah Based on your feedback, I created this False Positive report: jeremylong/DependencyCheck#6570

Please note that I could not find the CPE value, this way I wrote there unknown.
Could you please review my issue and provide me with details if I need to modify on something?

@aikebah
Copy link

aikebah commented Apr 9, 2024

@vmatyusGitHub The identifiers we would need (as far as present) can be found in the dependency-check-report.html that the CLI should create when you run it and it signals the FP.

I would expect an 'identifiers' section in there, which would look similar to (copied this from an unrelated other FP report's dependencycheck run:
IdentifiersSample

The 'package-url' for the FP report should be the value from such an identifiers section that starts with pkg:, the CPE is expected to be listed in there as well, otherwise I would not expect the False positive to be raised on the library.

Feel free to share the report with me (stripped of sensitive data if needed) at aikebah-github-issues (at) aikebah.net if with this extra info you can't find the items in the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants