Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gulp 4 #1

Closed
brendanfalkowski opened this issue Mar 13, 2019 · 2 comments
Closed

Update to Gulp 4 #1

brendanfalkowski opened this issue Mar 13, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@brendanfalkowski
Copy link
Member

brendanfalkowski commented Mar 13, 2019

Gulp 4 docs:
https://gulpjs.com/docs/en/getting-started/quick-start

@brendanfalkowski brendanfalkowski added the enhancement New feature or request label Mar 13, 2019
@brendanfalkowski brendanfalkowski self-assigned this Mar 13, 2019
@brendanfalkowski
Copy link
Member Author

brendanfalkowski commented Mar 13, 2019

The last hurdle to getting this working is resolving this issue, which causes the watch to stop recognizing changes in a JS file after an error is encountered:
gulpjs/gulp#359

Steps to reproduce

  1. Clone this repo
  2. Switch to branch issue/1-update-to-gulp-4
  3. Run npm install
  4. Run gulp watch
  5. Open the file js/src/module/thing.js
  6. Type some valid JS and save — note: the watcher reacts to each save
  7. Type invalid JS and save — note: the watcher reacts to saving once, then never again

Note — in gulpfile.js only the function jsThing() doesn't use createJsModule() which was meant to improve readability when dozens of modules exist in the build (all JS bundling tasks are the same). Retaining this is far less important making the watcher work after finding errors.

I think the issue lies in the return types, so I was trying to isolate the code for just one of the bundle creators when testing changes. I just couldn't find the right mix to keep the watcher working for JS (it does work for CSS).

brendanfalkowski added a commit that referenced this issue Mar 13, 2019
brendanfalkowski added a commit that referenced this issue Mar 13, 2019
brendanfalkowski added a commit that referenced this issue Mar 15, 2019
brendanfalkowski added a commit that referenced this issue Mar 15, 2019
brendanfalkowski added a commit that referenced this issue Mar 16, 2019
@brendanfalkowski
Copy link
Member Author

Merged fixes in from: #2

brendanfalkowski added a commit that referenced this issue Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant