Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private submodules in .gitmodules cause argocd failures #15123

Closed
soudaburger opened this issue Aug 2, 2022 · 2 comments
Closed

Private submodules in .gitmodules cause argocd failures #15123

soudaburger opened this issue Aug 2, 2022 · 2 comments
Labels

Comments

@soudaburger
Copy link

Not sure where this really goes, so feel free to relabel or otherwise change this issue as necessary.

We are using argocd to deploy/manage our teleport stack. Because of the way that teleport is managed (helm chart) the appVersion and the version are now identical values. We noticed an issue where, although we had not made changes on our end, there were now deltas with the teleport helm chart with regards to appResources (dynamic application registration).

As a result, we looked to take a different approach. We instead attempted to leverage git submodules to clone down the teleport repository with a specific tag, e.g., v10.1.0. We were able to get this to properly work locally, but because argocd performs a git submodule --init --recursive, it ALSO pulled in the .gitmodules from the teleport repository. However, the e repository at git@github.com:gravitational/teleport.e.git appears to be a private repository and since we don't have access to the repository, argocd applications simply fail to render at all when submodules simply exist in our repo.

Ultimate question: Is that private submodule actually used/needed? Is there a corresponding "public" branch that we could checkout similar to v10.1.0 but that wouldn't have the submodule included?

@soudaburger soudaburger added the bug label Aug 2, 2022
@zmb3
Copy link
Collaborator

zmb3 commented Aug 2, 2022

teleport.e is not needed for OSS teleport. It contains enterprise-specific code.

@zmb3
Copy link
Collaborator

zmb3 commented Dec 3, 2022

We won't be getting rid of private submodules, but the following issues might be worth following for updates. They also include a few suggested workarounds.

@zmb3 zmb3 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants