From f9dc9b00dbb52d0e7fabae5d0944c5eb2bd28c1a Mon Sep 17 00:00:00 2001
From: Ivan Goncharov <ivan.goncharov.ua@gmail.com>
Date: Wed, 22 May 2019 20:55:13 +0300
Subject: [PATCH] findBreakingChanges: Add new tests to improve coverage

---
 .../__tests__/findBreakingChanges-test.js     | 51 ++++++++++++++++---
 1 file changed, 43 insertions(+), 8 deletions(-)

diff --git a/src/utilities/__tests__/findBreakingChanges-test.js b/src/utilities/__tests__/findBreakingChanges-test.js
index bd1c342663..f4ee5f6b22 100644
--- a/src/utilities/__tests__/findBreakingChanges-test.js
+++ b/src/utilities/__tests__/findBreakingChanges-test.js
@@ -48,16 +48,31 @@ describe('findBreakingChanges', () => {
 
   it('should detect if a type changed its type', () => {
     const oldSchema = buildSchema(`
-      interface Type1
+      scalar TypeWasScalarBecomesEnum
+      interface TypeWasInterfaceBecomesUnion
+      type TypeWasObjectBecomesInputObject
     `);
 
     const newSchema = buildSchema(`
-      union Type1
+      enum TypeWasScalarBecomesEnum
+      union TypeWasInterfaceBecomesUnion
+      input TypeWasObjectBecomesInputObject
     `);
     expect(findBreakingChanges(oldSchema, newSchema)).to.deep.equal([
       {
         type: BreakingChangeType.TYPE_CHANGED_KIND,
-        description: 'Type1 changed from an Interface type to a Union type.',
+        description:
+          'TypeWasScalarBecomesEnum changed from a Scalar type to an Enum type.',
+      },
+      {
+        type: BreakingChangeType.TYPE_CHANGED_KIND,
+        description:
+          'TypeWasInterfaceBecomesUnion changed from an Interface type to a Union type.',
+      },
+      {
+        type: BreakingChangeType.TYPE_CHANGED_KIND,
+        description:
+          'TypeWasObjectBecomesInputObject changed from an Object type to an Input type.',
       },
     ]);
   });
@@ -566,6 +581,24 @@ describe('findBreakingChanges', () => {
     ]);
   });
 
+  it('should ignore changes in order of interfaces', () => {
+    const oldSchema = buildSchema(`
+      interface FirstInterface
+      interface SecondInterface
+
+      type Type1 implements FirstInterface & SecondInterface
+    `);
+
+    const newSchema = buildSchema(`
+      interface FirstInterface
+      interface SecondInterface
+
+      type Type1 implements SecondInterface & FirstInterface
+    `);
+
+    expect(findBreakingChanges(oldSchema, newSchema)).to.deep.equal([]);
+  });
+
   it('should detect all breaking changes', () => {
     const oldSchema = buildSchema(`
       directive @DirectiveThatIsRemoved on FIELD_DEFINITION
@@ -834,20 +867,22 @@ describe('findDangerousChanges', () => {
 
   it('should detect interfaces added to types', () => {
     const oldSchema = buildSchema(`
-      interface Interface1
+      interface OldInterface
+      interface NewInterface
 
-      type Type1
+      type Type1 implements OldInterface
     `);
 
     const newSchema = buildSchema(`
-      interface Interface1
+      interface OldInterface
+      interface NewInterface
 
-      type Type1 implements Interface1
+      type Type1 implements OldInterface & NewInterface
     `);
 
     expect(findDangerousChanges(oldSchema, newSchema)).to.deep.equal([
       {
-        description: 'Interface1 added to interfaces implemented by Type1.',
+        description: 'NewInterface added to interfaces implemented by Type1.',
         type: DangerousChangeType.INTERFACE_ADDED_TO_OBJECT,
       },
     ]);