Enable @typescript-eslint/strict-boolean-expressions rule #3872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Fix edge cases like in graphql#3869 Also I notice similar issue in graphql#3867 so I decided to fix it for the entire codebase.
IvanGoncharov
added
the
PR: polish 💅
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
|
You have successfully added a new CodeQL configuration |
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Apr 6, 2023
Context: I made this mistake in graphql#3872, fixing in this PR
IvanGoncharov
added a commit
that referenced
this pull request
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Fix edge cases like in #3869
Also, I notice a similar issue in #3867 so I decided to fix it for the entire codebase.
P.S. I also result in a small but measurable speedup probably because I replaced a bunch of
ObjMapwith ES6Map.