Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

printSchema: correctly print empty description #3869

Merged
merged 1 commit into from
Mar 30, 2023
Merged

printSchema: correctly print empty description #3869

merged 1 commit into from
Mar 30, 2023

Conversation

IvanGoncharov
Copy link
Member

Motivation: empty description is definetly a corner case but spec allow them so we should correctly print them

@IvanGoncharov IvanGoncharov added the PR: bug fix 🐞 requires increase of "patch" version number label Mar 29, 2023
@netlify
Copy link

netlify bot commented Mar 29, 2023 •
edited

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit ecc0db9
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/64256b3e6a194d00089b3b65
😎 Deploy Preview https://deploy-preview-3869--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pull_request.yml:codeql. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@IvanGoncharov
printSchema: correctly print empty description
ecc0db9 
Motivation: empty description is definetly a corner case but spec allow them so we should correctly print them
@IvanGoncharov IvanGoncharov merged commit 3cf08e6 into graphql:main Mar 30, 2023
19 checks passed
@IvanGoncharov IvanGoncharov deleted the pr_branch branch March 30, 2023 20:55
IvanGoncharov added a commit to IvanGoncharov/graphql-js that referenced this pull request Mar 31, 2023
@IvanGoncharov
Enable @typescript-eslint/strict-boolean-expressions rule
528d67a 
Motivation: Fix edge cases like in graphql#3869
Also I notice similar issue in graphql#3867 so I decided to fix it for the entire codebase.
@IvanGoncharov IvanGoncharov mentioned this pull request Mar 31, 2023
Merged
IvanGoncharov added a commit that referenced this pull request Apr 1, 2023
@IvanGoncharov
Enable @typescript-eslint/strict-boolean-expressions rule (#3872)
8c749e9 
Motivation: Fix edge cases like in #3869
Also, I noticed a similar issue in #3867, so I fixed it for the entire codebase.

P.S. I also resulted in a small but measurable speedup, probably because I replaced a bunch of ObjMap with ES6 Map.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@IvanGoncharov