Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Maybe to jsutils folder and remove tsutils #2621

Merged
merged 1 commit into from
Jun 6, 2020

Conversation

IvanGoncharov
Copy link
Member

No description provided.

@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Jun 6, 2020
@wodka
Copy link

wodka commented Jun 10, 2020

This change breaks Apollo Server

node_modules/@apollo/federation/dist/composition/utils.d.ts:3:19
  error TS2307: Cannot find module 'graphql/tsutils/Maybe' or its corresponding type declarations.

import Maybe from 'graphql/tsutils/Maybe';

@IvanGoncharov
Copy link
Member Author

@wodka Thanks for reporting 👍
It is an internal type not intended to be used outside of our package that is why it's not exported through intex.d.ts.
Can you please report it to the Apollo team?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants