Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS: isSpecifiedScalarType incorrectly refines type #2153

Closed
IvanGoncharov opened this issue Sep 3, 2019 · 1 comment · Fixed by #2196
Closed

TS: isSpecifiedScalarType incorrectly refines type #2153

IvanGoncharov opened this issue Sep 3, 2019 · 1 comment · Fixed by #2196
Labels
bug

Comments

@IvanGoncharov
Copy link
Member

Reported by @yaacovCR in #2104 (comment)

This line -- I think -- causes typescript to assume that a type that fails isSpecifiedScalarType test is actually not a GraphqlScalarType at all.

graphql-js/tstypes/type/scalars.d.ts

Line 11 in a482d3b

export function isSpecifiedScalarType(type: any): type is GraphQLScalarType;

tgriesser added a commit to tgriesser/graphql-js that referenced this issue Sep 23, 2019
@tgriesser
Correct isSpecifiedScalarType refinement, fix graphql#2153
8f87a9f
@tgriesser tgriesser mentioned this issue Sep 23, 2019
Closed
tgriesser added a commit to tgriesser/graphql-js that referenced this issue Sep 23, 2019
@tgriesser
Correct isSpecifiedScalarType refinement, fix graphql#2153
037caf9
IvanGoncharov added a commit to IvanGoncharov/graphql-js that referenced this issue Sep 24, 2019
@IvanGoncharov
tstypes: fix typings for 'isSpecifiedDirective'/'isSpecifiedScalarType'
f11cf53 
Fixes graphql#2153
@IvanGoncharov IvanGoncharov mentioned this issue Sep 24, 2019
Merged
IvanGoncharov added a commit to IvanGoncharov/graphql-js that referenced this issue Sep 24, 2019
@IvanGoncharov
Change 'isSpecified*' & 'isIntrospectionType' accept only correct types
f70bdbf 
Fixes graphql#2153
Previous disscussion: graphql#1837 (comment)
@IvanGoncharov IvanGoncharov mentioned this issue Sep 24, 2019
Merged
IvanGoncharov added a commit that referenced this issue Sep 25, 2019
@IvanGoncharov
tstypes: fix typings for 'isSpecifiedDirective'/'isSpecifiedSca… (#2195)
1a0e918 
Fixes #2153
@IvanGoncharov
Copy link
Member Author

Fixed in 14.5.8 📦
Long term solutions are proposed in #2194 and #2196

IvanGoncharov added a commit that referenced this issue Oct 1, 2019
@IvanGoncharov
Change 'isSpecified*' & 'isIntrospectionType' accept only correct typ…
730f5cc 
…es (#2196)

Fixes #2153
Previous disscussion: #1837 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@IvanGoncharov