tstypes: Use any as BREAK type.
#2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, TS will reposrt errors when a visit function only conditionally returns BREAK (not all paths return a value error)
IvanGoncharov
added
the
PR: bug fix 🐞
|
@JacksonKearl Thanks 👍 |
|
was setting the type or |
This was referenced Sep 7, 2019
Merged
This was referenced Oct 26, 2019
This was referenced Feb 12, 2020
This was referenced Feb 23, 2020
This was referenced Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, TS will reposrt errors when a visit function only conditionally returns BREAK (not all paths return a value error)