From 2afbf0b05b0a05175928f070eba86df6f6a97e10 Mon Sep 17 00:00:00 2001 From: Ivan Goncharov Date: Thu, 4 Jul 2019 14:55:31 +0300 Subject: [PATCH] Fix build after #1467 (#2014) --- src/subscription/__tests__/subscribe-test.js | 13 ++++++------- src/subscription/subscribe.js | 19 +++++++++---------- 2 files changed, 15 insertions(+), 17 deletions(-) diff --git a/src/subscription/__tests__/subscribe-test.js b/src/subscription/__tests__/subscribe-test.js index 958438f96d..008d1c333a 100644 --- a/src/subscription/__tests__/subscribe-test.js +++ b/src/subscription/__tests__/subscribe-test.js @@ -434,9 +434,9 @@ describe('Subscription Initialization Phase', () => { it('resolves to an error for source event stream resolver errors', async () => { // Returning an error - const subscriptionReturningErrorSchema = emailSchemaWithResolvers(() => { - return new Error('test error'); - }); + const subscriptionReturningErrorSchema = emailSchemaWithResolvers( + () => new Error('test error'), + ); await testReportsError(subscriptionReturningErrorSchema); // Throwing an error @@ -446,10 +446,8 @@ describe('Subscription Initialization Phase', () => { await testReportsError(subscriptionThrowingErrorSchema); // Resolving to an error - const subscriptionResolvingErrorSchema = emailSchemaWithResolvers( - async () => { - return new Error('test error'); - }, + const subscriptionResolvingErrorSchema = emailSchemaWithResolvers(() => + Promise.resolve(new Error('test error')), ); await testReportsError(subscriptionResolvingErrorSchema); @@ -1013,6 +1011,7 @@ describe('Subscription Publish Phase', () => { `), ); + // $FlowFixMe const payload1 = await subscription.next(); expect(payload1).to.deep.equal({ done: false, diff --git a/src/subscription/subscribe.js b/src/subscription/subscribe.js index 1066d5da1c..b2f4a23942 100644 --- a/src/subscription/subscribe.js +++ b/src/subscription/subscribe.js @@ -151,16 +151,15 @@ function subscribeImpl( // Resolve the Source Stream, then map every source value to a // ExecutionResult value as described above. - return sourcePromise.then( - resultOrStream => - // Note: Flow can't refine isAsyncIterable, so explicit casts are used. - isAsyncIterable(resultOrStream) - ? mapAsyncIterator( - ((resultOrStream: any): AsyncIterable), - mapSourceToResponse, - reportGraphQLError, - ) - : ((resultOrStream: any): ExecutionResult), + return sourcePromise.then(resultOrStream => + // Note: Flow can't refine isAsyncIterable, so explicit casts are used. + isAsyncIterable(resultOrStream) + ? mapAsyncIterator( + ((resultOrStream: any): AsyncIterable), + mapSourceToResponse, + reportGraphQLError, + ) + : ((resultOrStream: any): ExecutionResult), ); }