Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Mode graphql failed to advance stream' #932

Merged
merged 1 commit into from Aug 14, 2019
Merged

Fix 'Mode graphql failed to advance stream' #932

merged 1 commit into from Aug 14, 2019

Conversation

benjie
Copy link
Member

@benjie benjie commented Aug 12, 2019

Fixes #735

Basically the bad token wasn't being "eaten" so it literally was failing to advance the stream. This fix consumes it.

Screenshot_20190812_142416

@benjie
Copy link
Member Author

benjie commented Aug 12, 2019

@acao
Copy link
Member

acao commented Aug 12, 2019

Once the user confirms this fix, we can merge this, release GLS, codemirror-graphql, and then graphiql. GraphiQL in master currently depends on unpublished dependency versions FYI!

@acao
Copy link
Member

acao commented Aug 12, 2019

If this is an issue with gls-parser, then we should also see this bug in insomnia and playground

@Neitsch
Copy link
Contributor

Neitsch commented Aug 12, 2019

Is this issue specific to whitespaces or unicode characters overall? If it's the latter maybe we can tackle unicode characters more broadly in this PR?

@benjie
Copy link
Member Author

benjie commented Aug 12, 2019

Lets do that in a separate PR @Neitsch; this PR is very localised to one specific issue and it already handles /\S+/ and /\s/ so there's no more characters it can handle (since /[\S\s]/ covers all possible characters).

@robinmetral
Copy link

@benjie @acao sorry for my late reply, fix confirmed! 🎉

@acao acao merged commit 75f4570 into master Aug 14, 2019
@robinmetral
Copy link

@acao do you know when the next release will be? I'm looking forward to bringing this fix to Gatsby 🚀

@acao
Copy link
Member

acao commented Aug 14, 2019

@robinmetral this week, ideally!

@benjie benjie deleted the fix-735 branch August 14, 2019 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught Error: Mode graphql failed to advance stream.
4 participants