Stringify subscription errors elegantly to avoid [object Object] errors
#722
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| @@ -574,7 +574,7 @@ export class GraphiQL extends React.Component { | |||
| error: error => { | |||
| this.setState({ | |||
| isWaitingForResponse: false, | |||
| response: error && String(error.stack || error), | |||
| response: this.makeSubscriptionErrorResponse(error), | |||
There was a problem hiding this comment.
Would you mind keeping the original null check for error?
|
there are several issues regarding this, would be good to get this one released very soon |
|
Ugh, I just accidentally added to this pile of error solutions: |
|
The idea of accessing |
No description provided.