Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tsconfig.esm.json to not target ESNext #2291

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

retrodaredevil
Copy link
Contributor

I believe #2247 was supposed to fix this, but that change does not seem to be in the main branch.

Closes #2240

I believe graphql#2247 was supposed to fix this, but that change does not seem to be in the main branch.

Closes graphql#2240
@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2022

🦋 Changeset detected

Latest commit: 59bec89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
graphql-language-service Patch
graphql-language-service-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 11, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: retrodaredevil / name: Joshua Shannon (01ae119)

@acao
Copy link
Member

acao commented Apr 12, 2022

@retrodaredevil can you add a changeset so that there is a release? thank you!

@retrodaredevil
Copy link
Contributor Author

retrodaredevil commented Apr 13, 2022

I included graphql-language-service and graphql-language-service-cli in the changeset. Let me know if I need to include more or less stuff. I basically just copied what you did in 3626f8d, but I didn't add yarn.lock to my changes. Not sure if I needed to or not.

Now that I comparing ours, it may not need graphql-language-service-cli, since it's not like I changed any dependencies or anything. Let me know if I need to remove that.

@acao
Copy link
Member

acao commented Apr 14, 2022

Thanks @retrodaredevil ! It will automatically increment the dependent modules. Looks good thanks!

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #2291 (59bec89) into main (2d91916) will decrease coverage by 0.98%.
The diff coverage is 73.92%.

@@            Coverage Diff             @@
##             main    #2291      +/-   ##
==========================================
- Coverage   65.70%   64.72%   -0.99%     
==========================================
  Files          85       81       -4     
  Lines        5106     5315     +209     
  Branches     1631     1701      +70     
==========================================
+ Hits         3355     3440      +85     
- Misses       1747     1871     +124     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ackages/codemirror-graphql/src/utils/info-addon.ts 1.02% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc3fdc7...59bec89. Read the comment docs.

@acao acao merged commit 45cbc75 into graphql:main Apr 14, 2022
@github-actions github-actions bot mentioned this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optional chaining for graphql-language-service@5.0.0 breaks upstream build
2 participants