Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more vscode-graphql migration #2283

Merged
merged 1 commit into from Apr 7, 2022
Merged

more vscode-graphql migration #2283

merged 1 commit into from Apr 7, 2022

Conversation

acao
Copy link
Member

@acao acao commented Apr 7, 2022

  • we forgot .vscodeignore so the extension is publishing HUGE now
  • open vsix requires full --pat argument now?

@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2022

⚠️ No Changeset found

Latest commit: 1af9e04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2022

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #2283 (1af9e04) into main (2d91916) will decrease coverage by 0.98%.
The diff coverage is 73.92%.

@@            Coverage Diff             @@
##             main    #2283      +/-   ##
==========================================
- Coverage   65.70%   64.72%   -0.99%     
==========================================
  Files          85       81       -4     
  Lines        5106     5315     +209     
  Branches     1631     1716      +85     
==========================================
+ Hits         3355     3440      +85     
- Misses       1747     1871     +124     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ackages/codemirror-graphql/src/utils/info-addon.ts 1.02% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f39cd75...1af9e04. Read the comment docs.

@acao acao merged commit 931b8b4 into main Apr 7, 2022
@acao acao deleted the vsce-yarn branch April 7, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant