Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 7th meeting notes :) #1978

Merged
merged 2 commits into from Oct 29, 2021
Merged

Add 7th meeting notes :) #1978

merged 2 commits into from Oct 29, 2021

Conversation

patrick91
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2021

⚠️ No Changeset found

Latest commit: e737335

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR%0A)

@acao
Copy link
Member

acao commented Oct 13, 2021

wish I could've made it!

important details:

  • feat/use-context-hooks branch is outdated, that work was merged to packages/graphiql-2-context-rfc and continued as an WIP. it's a good starting point to approach this new architecture, especially as a start for monaco + hooks, but context is obviously not the solution for this. lots of needless re-renders and ui twitching
  • we need to continue to build out @graphiql/react and @graphiql/toolkit as per the proposal Dual Editors - an Alternative 2.0 Architectural Proposal #1787. there is a PR for @graphiql/react already
  • also important: https://graphql.org/blog/2020-04-03-web-based-graphql-ides-for-the-win/ this is the main reason behind the proposed architecture, and the direction towards an SDK approach for 2.0

@acao
Copy link
Member

acao commented Oct 13, 2021

January -> Spring 2020 saw a ton of effort in this direction towards react 16, hooks and adopting monaco. @ryan-m-walker @cshaver @zephraph and many others were involved. I think the weird dance I did with merging that feature branch to main caused me to accidentally overwrite some of their contribution credit :( The code is all there, just missing attribution

…of github.com:patrick91/graphiql into pr/patrick91/1978
@acao acao merged commit 1aa10a6 into graphql:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants