Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support interfaces that implement other interfaces #44

Closed
obi1kenobi opened this issue Mar 2, 2021 · 1 comment · Fixed by #49
Closed

Support interfaces that implement other interfaces #44

obi1kenobi opened this issue Mar 2, 2021 · 1 comment · Fixed by #49

Comments

@obi1kenobi
Copy link
Contributor

It seems that graphql-parser currently does not allow interfaces to extend other interfaces. This is a feature that was released in the most recent GraphQL.js major release, v15, and allows some neat functionality: https://dev.to/mikemarcacci/intermediate-interfaces-generic-utility-types-in-graphql-50e8

Direct link to the PR where this was added to the GraphQL spec: graphql/graphql-spec#373
Link to the GraphQL.js PR where this functionality was added: graphql/graphql-js#2084

I'm still learning Rust but I'm open to helping implement this if the maintainers don't mind reading code from a Rust noob 😃

@tailhook
Copy link
Collaborator

tailhook commented Mar 3, 2021

This looks like a simple feature. Start with tests. Then update data structures, then you will see compiler errors and it should be easy enough to add grammar rules to fix these compiler errors. Grammar is quite non-trivial Rust code, but these rules should have similar examples in other parts of grammar so should be easy to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants