Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Inherit Execute Options for GraphQLView Methods #78

Open
KingDarBoja opened this issue Dec 12, 2020 · 1 comment
Open

RFC: Inherit Execute Options for GraphQLView Methods #78

KingDarBoja opened this issue Dec 12, 2020 · 1 comment
Labels
type: rfc Use this label for RFCs (request for comments) for broad, sweeping changes to graphql-server-core

Comments

@KingDarBoja
Copy link
Contributor

Related to #77.

Currently the execute() method from graphql-core provides several keyword arguments to be passed on, which aren't included at all on such GraphQLView class methods. These can be passed using the **kwargs syntax but should be great to infer from execute() the available options.

So far this is being discussed at PEP-0612 and the tracking issue as this use case was discussed at this typing repository issue.

The only workaround is to manually specify the same types in order to provide each integration with the same capabilities from graphql-core out of the box.

cc @Cito

@KingDarBoja KingDarBoja added the type: rfc Use this label for RFCs (request for comments) for broad, sweeping changes to graphql-server-core label Dec 12, 2020
@kiendang
Copy link
Collaborator

After spending time reading the specs, I don't think PEP 612's gonna help with this use case at all. The ParametersOf and ReturnType operators, which were listed under "Rejected Alternatives", would actually help, which is unfortunate. Guess we'd still have to manually specify the same types for each framework integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: rfc Use this label for RFCs (request for comments) for broad, sweeping changes to graphql-server-core
Projects
None yet
Development

No branches or pull requests

2 participants