Bugfix: Cast error message to string to handle proxy objects #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkimbo
force-pushed
the
cast-error-messages-to-string
branch
2 times, most recently
from
3a1aa29
to
6a9f820
Compare
jkimbo
force-pushed
the
cast-error-messages-to-string
branch
from
6a9f820
to
a5450f0
Compare
|
I changed my approach to this fix by forcing the error message to a string in the |
|
Thanks @Cito |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some frameworks (Django as an example) use a lazy evaluated object to represent error messages (https://github.com/django/django/blob/49b470b9187b6be60e573fed08c8f4a87f133750/django/utils/functional.py#L87-L96). This breaks graphql-core when it tries to format the error as a string.
This PR fixes this bug by forcing the error message to a string when creating a GraphQLError object.