Represent serialized floats to python float precision #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cito
requested changes
Apr 1, 2022
Cito
requested changes
Apr 2, 2022
Cito
approved these changes
Apr 2, 2022
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the general string format used in the serialisation of a float value uses the default precision of 6, which leads to a loss in precision of large/long numbers. This PR changes the precision to use up to 16 places, which is approximately the level of precision of a float. This doesn't have any impact on the existing tests that don't have numbers with precision > 6, and the added assertion in the existing test fails without the change.