fix runtime exception for deep async queries #2842
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Resolving large queries with more than 16 async levels throws this error:
The issue appears to be that inside FieldLevelTrackingApproach.levelReady, we're checking the
allFetchesHappened
LevelMap when it may not have been expanded to the specified level. This is not an issue for small queries that can fit under the default size of 16 levels, but throws an exception for more nested async queries. This issue effects all "happened"-ish LevelMaps in FieldLevelTrackingApproachSolution
In
LevelMap.get
automatically resize if needed. This allows deep queries to match the behavior of shallow queries which do not need to resize their LevelMaps.