New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression in GraphQLScalarType Coercing parseValue in 18.1 #2819
Comments
Additional details which may be helpful I’m using both the max depth and query complexity limiting instrumentations provided by graphql java |
This has been fixed in a 18.1 release in this PR : #2773 It was specific to a new way to co-erce variables combined with either of those two instrumentations |
To clarify this is new behavior only after upgrading to 18.1 from 18.0. I’m familiar with the previous issue. Something changes in the fix for that that broke. Existing coercers now seemed passed arguments that were already coerced. I’m not sure if that is new expected behavior or not |
Sorry I didnt read the bug report well enough - yes we have found a place where values are getting double co-erced. This is not new - the double co-ercion was always there - however what happens during co-ercion IS new and hence the existing double co-ercion bug is now hurting. We are looking at this |
Thanks. I'll be cheering you on from the sidelines! |
I just wanted to confirm the fix. I just upgraded to 18.2 in production without issue. Thank you so much for the fix! |
Describe the bug
I just hit a bug in production when deploying an upgrade from 18.0 to 18.1 that I think relates to some of the work in resolving #2811
I noticed the following in my production logs
note that the string
2022-05-16T19:52:37Z
is actually parsable as ZonedDateTime however I believe the issue is previouslyparseValue
was receiving either a String or a StringValue and after this upgrade it started receiving the value that I was attempting to coerce it into, in this case a ZonedDateTimeis this new expected behavior or was this previous expected behavior that was underspecified until now?
Here's an abbreviated version of a custom scaler for parsing out ZonedDateTime values which is roughly based on the docs
To Reproduce
Please provide a code example or even better a test to reproduce the bug.
see above
The text was updated successfully, but these errors were encountered: