Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing authorization extensions from field and connection builders #3324

Merged
merged 1 commit into from Sep 16, 2022
Merged

Add missing authorization extensions from field and connection builders #3324

merged 1 commit into from Sep 16, 2022

Conversation

Shane32
Copy link
Member

@Shane32 Shane32 commented Sep 13, 2022

@Shane32 Shane32 self-assigned this Sep 13, 2022
@Shane32
Copy link
Member Author

Shane32 commented Sep 13, 2022

In the next version of GraphQL.NET, perhaps the field and connection builders should implement IMetadataProvider so these methods can be removed.

@Shane32 Shane32 added this to the 7.1 milestone Sep 13, 2022
@Shane32 Shane32 mentioned this pull request Sep 16, 2022
Closed
@Shane32 Shane32 merged commit e7dbf99 into master Sep 16, 2022
@Shane32 Shane32 deleted the auth_extensions branch September 16, 2022 14:47
@sungam3r
Copy link
Member

In the next version of GraphQL.NET, perhaps the field and connection builders should implement IMetadataProvider so these methods can be removed.

Indeed. And I have a vague feeling that I had already tried to do so.

Kent-Chen-Conning added a commit to Conning/graphql-dotnet that referenced this pull request Oct 28, 2022
@Kent-Chen-Conning
Merge commit '13da37d7c0649cc6186714a6671272af49f06d85' into feature/…
b7f6428 
…TRAC-6694-upgrade-graphql-dotnet-server-to-7.1

* commit '13da37d7c0649cc6186714a6671272af49f06d85': (1255 commits)
  Add type integrity check when existing types are found (graphql-dotnet#3332)
  Switch to Nullability.Source (graphql-dotnet#3314)
  Add missing authorization extensions from field and connection builders (graphql-dotnet#3324)
  Prevent using graphtype as model (graphql-dotnet#3316)
  Remove init-only properties from pre-.NET 5 targets (graphql-dotnet#3323)
  Update UnionGraphType to support CLR references (graphql-dotnet#3320)
  Bump BenchmarkDotNet from 0.13.1 to 0.13.2 (graphql-dotnet#3313)
  Bump Microsoft.NET.Test.Sdk from 17.3.0 to 17.3.1 (graphql-dotnet#3311)
  Fix InputFieldsAndArgumentsOfCorrectLength validation rule (graphql-dotnet#3307)
  Bump Shouldly from 4.0.3 to 4.1.0 (graphql-dotnet#3304)
  Add test (graphql-dotnet#3302)
  !(a is T) -> a is not T (graphql-dotnet#3300)
  User not duplicated in context (graphql-dotnet#3298)
  Bump deps (graphql-dotnet#3295)
  Restore `Field<TGraphType>()` method (graphql-dotnet#3294)
  Include v7 migration document link in readme (graphql-dotnet#3290)
  Bump GraphQL-Parser to 8.1.0 (graphql-dotnet#3289)
  Migration notes updates (graphql-dotnet#3287)
  Simplify configuration (graphql-dotnet#3286)
  Introduce ErrorInfoProviderOptions.ExposeExceptionDetailsMode (graphql-dotnet#3276)
  ...

# Conflicts:
#	docs/package.json
#	src/GraphQL/GraphQL.csproj
#	src/GraphQL/Types/GraphTypesLookup.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungam3r sungam3r Awaiting requested review from sungam3r

Assignees

@Shane32 Shane32

Labels
None yet
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shane32 @sungam3r