Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Nullability.Source #3314

Merged
merged 1 commit into from Sep 16, 2022
Merged

Switch to Nullability.Source #3314

merged 1 commit into from Sep 16, 2022

Conversation

sungam3r
Copy link
Member

@sungam3r sungam3r commented Sep 5, 2022

изображение

@codecov-commenter
Copy link

Codecov Report

Merging #3314 (8373227) into master (80b966e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3314   +/-   ##
=======================================
  Coverage   84.04%   84.04%           
=======================================
  Files         376      376           
  Lines       16179    16179           
  Branches     2600     2600           
=======================================
  Hits        13597    13597           
  Misses       1964     1964           
  Partials      618      618

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sungam3r
Copy link
Member Author

sungam3r commented Sep 5, 2022

@Shane32 By the way I always have some issues with NullabilityInfo package when working locally in VS 2022
изображение
The same for this new package. dotnet build from console works fine.
изображение
ping @SimonCropp

@sungam3r sungam3r self-assigned this Sep 5, 2022
@sungam3r sungam3r added the dependencies Pull request that updates a dependency file label Sep 5, 2022
@Shane32
Copy link
Member

Shane32 commented Sep 6, 2022

@sungam3r I have no problems with the VS IDE in this respect on any of my computers. Is there any chance that you have set SingleTestPlatform and this is causing this issue? (Just guessing because I can't think of any other reason.)

Peeking at the definition for me properly shows either the .NET reference or the NullabilityInfo instance depending on the platform selection in the dropdown.

image

@Shane32
Copy link
Member

Shane32 commented Sep 6, 2022

This PR seems to work fine also for me.

image

@Shane32
Copy link
Member

Shane32 commented Sep 6, 2022

Note that I have been using VS 2022 awhile and am using 17.3.2 now

@Shane32 Shane32 merged commit c2faf94 into master Sep 16, 2022
@Shane32 Shane32 deleted the nullable branch September 16, 2022 14:47
@sungam3r
Copy link
Member Author

sungam3r commented Sep 19, 2022 •
edited

Nope, SingleTestPlatform is false in my local Tests.local.props file. I will make another attempt to figure it out later.

Kent-Chen-Conning added a commit to Conning/graphql-dotnet that referenced this pull request Oct 28, 2022
@Kent-Chen-Conning
Merge commit '13da37d7c0649cc6186714a6671272af49f06d85' into feature/…
b7f6428 
…TRAC-6694-upgrade-graphql-dotnet-server-to-7.1

* commit '13da37d7c0649cc6186714a6671272af49f06d85': (1255 commits)
  Add type integrity check when existing types are found (graphql-dotnet#3332)
  Switch to Nullability.Source (graphql-dotnet#3314)
  Add missing authorization extensions from field and connection builders (graphql-dotnet#3324)
  Prevent using graphtype as model (graphql-dotnet#3316)
  Remove init-only properties from pre-.NET 5 targets (graphql-dotnet#3323)
  Update UnionGraphType to support CLR references (graphql-dotnet#3320)
  Bump BenchmarkDotNet from 0.13.1 to 0.13.2 (graphql-dotnet#3313)
  Bump Microsoft.NET.Test.Sdk from 17.3.0 to 17.3.1 (graphql-dotnet#3311)
  Fix InputFieldsAndArgumentsOfCorrectLength validation rule (graphql-dotnet#3307)
  Bump Shouldly from 4.0.3 to 4.1.0 (graphql-dotnet#3304)
  Add test (graphql-dotnet#3302)
  !(a is T) -> a is not T (graphql-dotnet#3300)
  User not duplicated in context (graphql-dotnet#3298)
  Bump deps (graphql-dotnet#3295)
  Restore `Field<TGraphType>()` method (graphql-dotnet#3294)
  Include v7 migration document link in readme (graphql-dotnet#3290)
  Bump GraphQL-Parser to 8.1.0 (graphql-dotnet#3289)
  Migration notes updates (graphql-dotnet#3287)
  Simplify configuration (graphql-dotnet#3286)
  Introduce ErrorInfoProviderOptions.ExposeExceptionDetailsMode (graphql-dotnet#3276)
  ...

# Conflicts:
#	docs/package.json
#	src/GraphQL/GraphQL.csproj
#	src/GraphQL/Types/GraphTypesLookup.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shane32 Shane32 Shane32 approved these changes

Assignees

@sungam3r sungam3r

Labels
dependencies Pull request that updates a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sungam3r @codecov-commenter @Shane32