Directive "@deprecated" for arguments in SDL is ignored

[vladar]

Looks like the @deprecated directive for arguments in SDL is ignored. Check out the example:

const typeComposer = typeMapper.convertSDLTypeDefinition(`
  type Foo {
    foo(
      arg: String @deprecated(reason: "Tired")
    ): String
  }
`);

Now if I try building this type it renders without the @deprecated directive:

import { printType } from "graphql";

printType(typeComposer.getType());

// prints this:
//   type Foo {
//     foo(arg: String): String
//   }

I wanted to fix it and open a PR but looks like this is intentional:

graphql-compose/src/TypeMapper.js

Lines 1120 to 1124 in bd3bc96

	if (name === GraphQLDeprecatedDirective.name) {
	// @deprecated directive should be parsed via getDeprecationReason() method
	// It's due to fact that deprecated is stored as separate type instance's field.
	return;
	}

So not sure what is the best course of action here. Any thoughts?

[nodkz]

I've spent several hours trying to figure out this problem without lack.
If we remove this logic the the test 254 fails with the following error (duplication of deprecated directive):

Even more, there is another problem with directives for args. When I remove 1120-1124 lines then printType method does not add directive properly.

@vladar may I ask you to open a new PR with your fix? Please ignore the 254 test suite I'll fix it myself and add the following test suite:

/* @flow */

import { printType } from 'graphql';
import { schemaComposer, dedent } from '../..';

describe('github issue #317: Directive @deprecated for arguments in SDL is ignored ', () => {
  it('should build schema successfully', async () => {
    const typeComposer = (schemaComposer.typeMapper.convertSDLTypeDefinition(`
      type Foo {
        foo(
          arg: String @deprecated(reason: "Tired")
        ): String
      }
    `): any);

    const type = typeComposer.getType();

    expect(printType(type)).toEqual(dedent`
      type Foo {
        foo(
          arg: String @deprecated(reason: "Tired")
        ): String
      }
    `);
  });
});

[vladar]

I switched to something else at the moment. But will try to come up with a PR next week.

[github-actions]

🎉 This issue has been resolved in version 9.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀