-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
withPgClient
is intended for mutations - make it clear!
#2044
Comments
For uses of withPgClient that do not do mutations, am I right in understanding that by setting This is also hinted at here #2045 I wonder if there's value in adding a |
No, that is not correct. We added a warning right at the top of the docs page saying it doesn’t use batching: https://grafast.org/grafast/step-library/dataplan-pg/withPgClient Definitely worth looking out for these kinds of warnings. Might make sense for us to put “unbatched” in the name, perhaps. We should maybe create a |
Is this true for any usage of Even if the |
Depending on |
e.g. the example here: https://postgraphile.org/postgraphile/next/make-extend-schema-plugin#example-2 would result in N+1 problem if applied to a non-root type. Need some serious caveats on the withPgClient page and throughout the docs where it's used.
The text was updated successfully, but these errors were encountered: