Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macros that have nested functions with multi params do not work #97

Closed
bossinc opened this issue Sep 1, 2023 · 0 comments · Fixed by #98
Closed

Macros that have nested functions with multi params do not work #97

bossinc opened this issue Sep 1, 2023 · 0 comments · Fixed by #98
Assignees

Comments

@bossinc
Copy link
Contributor

bossinc commented Sep 1, 2023

This is coming from grafana/clickhouse-datasource#454

If you have a macro that is expecting one param like $__singleParamMacro and you nest a function in that macro like $__singleParamMacro(nestedFunc("foo","bar")) it will split on the comma resulting in two params nestedFunc("foo" and "bar")

We need an RE that does not find commas in nested () and [].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant