Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to sqlutil helpers #85

Closed
iwysiu opened this issue Jan 12, 2023 · 1 comment · Fixed by #107
Closed

Update to sqlutil helpers #85

iwysiu opened this issue Jan 12, 2023 · 1 comment · Fixed by #107

Comments

@iwysiu
Copy link
Contributor

iwysiu commented Jan 12, 2023

In https://github.com/grafana/cloud-data-sources/issues/94 some standalone sql helper functions were copied to sqlutil in the plugin sdk. Use those here instead to deduplicate code.

@gabor
Copy link
Contributor

gabor commented Dec 5, 2023

NOTE: it seems the macros.go in pluginsdk, at the time of writing this comment, corresponds to macros.go in sqlds at commit cd68d26e53cdfd799f700d4623f9f3c946101fb3 : cd68d26

  • it contains the quick exit from the loop comment that was added in that comment
  • it does not contain the when we are inside an argument comment that was added in the next macros.go-touching commit ( 6cccadd )

since that commit in sqlds, there has been changes done to macros.go in sqlds, so those changes will have to be applied to the pluginsdk version too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants