Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix connection leak on query retry reconnect #79

Merged
merged 3 commits into from Dec 6, 2022
Merged

Fix connection leak on query retry reconnect #79

merged 3 commits into from Dec 6, 2022

Conversation

jkaflik
Copy link
Contributor

@jkaflik jkaflik commented Dec 4, 2022 •
edited

Solves an issue described in grafana/clickhouse-datasource#253

Close all connections released before reconnect attempt.

@CLAassistant
Copy link

CLAassistant commented Dec 4, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@jkaflik
Copy link
Contributor Author

jkaflik commented Dec 5, 2022

@scottlepp can you have a look at this? thanks

@jkaflik jkaflik changed the title Close released conn on a reconnect attempt Fix connection leak on query retry reconnect Dec 5, 2022
@bossinc bossinc merged commit e30c0ed into grafana:main Dec 6, 2022
@cletter7 cletter7 mentioned this pull request Dec 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottlepp scottlepp scottlepp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jkaflik @CLAassistant @scottlepp @bossinc