Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retries, ping timeout, sql mock handler #75

Merged
merged 5 commits into from Nov 10, 2022
Merged

retries, ping timeout, sql mock handler #75

merged 5 commits into from Nov 10, 2022

Conversation

scottlepp
Copy link
Collaborator

  • support retries - for situations where the db is temporarily unavailable
  • use timeout setting when pinging - there is a timeout setting but ping didn't use it
  • sql mock driver registry
    • allow providing a handler to handle ping, results - provides more control when mocking a driver

@scottlepp scottlepp changed the title retries retries, ping timeout, sql mock handler Nov 10, 2022
Copy link
Contributor

@yesoreyeram yesoreyeram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. any reason csv_mock.go was moved outside? Keeping the mock outside on its own package is suggested.

@scottlepp
Copy link
Collaborator Author

scottlepp commented Nov 10, 2022

@yesoreyeram yes there is a circular dependency :(

EDIT: fixed

@scottlepp scottlepp merged commit cdeb646 into main Nov 10, 2022
@scottlepp scottlepp deleted the sql-mock branch November 10, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants