Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CallGraph query API #3219

Open
kolesnikovae opened this issue Apr 15, 2024 · 0 comments · May be fixed by #3178
Open

Add CallGraph query API #3219

kolesnikovae opened this issue Apr 15, 2024 · 0 comments · May be fixed by #3178
Labels
backend Mostly go code enhancement New feature or request

Comments

@kolesnikovae
Copy link
Collaborator

Despite the fact that a call graph can be built from a flame graph or a profile in pprof format, the new use-case specific API will significantly help us integrate call graphs into the Pyroscope UI.

The issue lies in the fact that truncating flame graphs/pprof profiles is not suitable for call graphs: the heuristics we use to trim insignificant nodes make the call graph incorrect. A workaround could be keeping all the nodes (disabling the truncation); however, this will not work well with large profiles. Thus, it's preferable to build call graphs in the backend, trimming nodes in a way optimized for call graphs; otherwise, we will be juggling between incorrect call graph structures/numbers and very poor performance.

@kolesnikovae kolesnikovae added enhancement New feature or request backend Mostly go code labels Apr 15, 2024
@kolesnikovae kolesnikovae linked a pull request Apr 15, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Mostly go code enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant