Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message when using negative offset is misleading #576

Closed
simonswine opened this issue Dec 2, 2021 · 2 comments · Fixed by #688
Closed

Error message when using negative offset is misleading #576

simonswine opened this issue Dec 2, 2021 · 2 comments · Fixed by #688

Comments

@simonswine
Copy link
Contributor

Describe the bug

The error message when using negative offset is at best misleading, as it refers to the Prometheus flag and the feature flag does not exist in Mimir

negative offset is disabled, use --enable-feature=promql-negative-offset to enable it

To Reproduce

Query using negative offset

count_over_time(up[1m] offset -10s)

Expected behavior

Adding a feature flag and display an error mentioning the correct flag -querier.at-modifier-enabled or always enable it in Mimir or mention that negative offsets are not supported in Mimir

@pstibrany
Copy link
Member

Negative offsets may be enabled by default (without possibility to disable them) in PromQL soon: prometheus/prometheus#10121

@pstibrany
Copy link
Member

pstibrany commented Jan 6, 2022

Negative offsets may be enabled by default (without possibility to disable them) in PromQL soon: prometheus/prometheus#10121

Oh, I misread the PR. It actually doesn't remove the option to enable/disable negative offsets, nor does it make them enabled by default. It just removes "experimental" designation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants