Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new Prometheus client's DeletePartialMatch() #1764

Closed
pracucci opened this issue Apr 27, 2022 · 0 comments · Fixed by #2660
Closed

Use the new Prometheus client's DeletePartialMatch() #1764

pracucci opened this issue Apr 27, 2022 · 0 comments · Fixed by #2660
Labels
chore

Comments

@pracucci
Copy link
Collaborator

Prometheus client introduced MetricVec.DeletePartialMatch() in prometheus/client_golang#1013. This originates from an old standing request we had when we worked on cortexproject/cortex#3784 and follow up PRs. I think we can now remove our DeleteMatchingLabels() utility and leverage on the new built-in DeletePartialMatch().
@pracucci pracucci added enhancement New feature or request chore and removed enhancement New feature or request labels Apr 27, 2022
@LeviHarrison LeviHarrison mentioned this issue Aug 6, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use DeletePartialMatch() LeviHarrison/mimir
1 participant
@pracucci