JSON: Accessing string from array leads to Unknown value type error
#9179
Labels
Comments
|
This appears to be an oddity in the underlying JSON parser. When the string is either wrapped in a JSON object or in a 2-dimensional array, it suddenly does manage to parse. |
|
Any news on this one? Looks very odd indeed. |
|
It works if the string can be parsed to a 'known' type, i.e. "21:12:12", "500"
|
|
After more sleuthing, it seems to have been introduced by #8734 and would be related to buger/jsonparser#232 |
This was referenced Sep 22, 2023
|
Hi, any news? |
8 tasks
paul1r
added a commit
that referenced
this issue
Feb 13, 2024
…#11921) **What this PR does / why we need it**: This PR imports the newly forked grafana/jsonparser over the buger/jsonparser module. The latter has seemingly been abandoned. PR 10690 introduces a fix to the jsonparser module, which has been incorporated into the grafana fork of the module. The PR is designed to fix accessing string array elements from within a JSON structure. For example, with the following JSON: `{"log":{"message":{"content":{"misses":["a","b","c","d"]}}}}` The Loki code, before this PR, when searching for `json misses = "log.message.content.misses[0]" ` will result in an "Unknown value type error". After this PR is merged, the result will assign `a` to the `misses` variable. **Which issue(s) this PR fixes**: Fixes #[9179](#9179) #10690 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [x] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](d10549e) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](0d4416a)
|
Hello, apologies for the delay! I've integrated a fix today that should fix this issue. If it does not, please reopen this. |
rhnasc
pushed a commit
to inloco/loki
that referenced
this issue
Apr 12, 2024
…grafana#11921) **What this PR does / why we need it**: This PR imports the newly forked grafana/jsonparser over the buger/jsonparser module. The latter has seemingly been abandoned. PR 10690 introduces a fix to the jsonparser module, which has been incorporated into the grafana fork of the module. The PR is designed to fix accessing string array elements from within a JSON structure. For example, with the following JSON: `{"log":{"message":{"content":{"misses":["a","b","c","d"]}}}}` The Loki code, before this PR, when searching for `json misses = "log.message.content.misses[0]" ` will result in an "Unknown value type error". After this PR is merged, the result will assign `a` to the `misses` variable. **Which issue(s) this PR fixes**: Fixes #[9179](grafana#9179) grafana#10690 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [ ] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [x] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](grafana@d10549e) - [ ] If the change is deprecating or removing a configuration option, update the `deprecated-config.yaml` and `deleted-config.yaml` files respectively in the `tools/deprecated-config-checker` directory. [Example PR](grafana@0d4416a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Given a JSON logline
{"foo":["bar"]}and trying to access thebarstring from it leads to aUnknown value typeerror.You can see it here: https://grafana.com/docs/loki/latest/logql/analyzer/?query=%7C+json+baz%3D%22foo%5B0%5D%22&line%5B%5D=%7B%22foo%22%3A%5B%22bar%22%5D%7D
Using number arrays works as expected: https://grafana.com/docs/loki/latest/logql/analyzer/?query=%7C+json+baz%3D%22foo%5B0%5D%22&line%5B%5D=%7B%22foo%22%3A%5B1%5D%7D
To Reproduce
Steps to reproduce the behavior:
Expected behavior
String slices should be parsed as number slices.
Environment:
The text was updated successfully, but these errors were encountered: