Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.3.0: x_build_info isn't emitting the version label anymore. #4587

Closed
frittentheke opened this issue Oct 29, 2021 · 8 comments
Closed

v2.3.0: x_build_info isn't emitting the version label anymore. #4587

frittentheke opened this issue Oct 29, 2021 · 8 comments

Comments

@frittentheke
Copy link
Contributor

Describe the bug
loki_build_info and promtail_build_info isn't emitting version anymore.
This was reported (and fixed?) in #1208 before.

To Reproduce
Steps to reproduce the behavior:

  1. Start Loki & Promtail 2.3.0
  2. Scrape both components with Prometheus
  3. Retrieve the loki_build_info and promtail_build_info metrics
  4. Inspect that the 'version' label is missing.

Expected behavior
The 'version' label with current version of loki and promtail in the metrics promtail_build_info and loki_build_info

Environment:

  • Infrastructure: bare-metal
  • Deployment tool: Ansible

Screenshots, Promtail config, or terminal output
There also is no build user / date for 2.3.0 vs. 2.2.1 anymore ...

./loki-linux-amd64 --version 
loki, version 2.2.1 (branch: HEAD, revision: babea82e)
  build user:       root@e2d295b84e26
  build date:       2021-04-06T00:52:41Z
  go version:       go1.15.3
  platform:         linux/amd64
./loki-linux-amd64 --version
loki, version  (branch: , revision: )
  build user:       
  build date:       
  go version:       go1.16.2
  platform:         linux/amd64
@stale
Copy link

stale bot commented Jan 9, 2022

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely
    to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Jan 9, 2022
@frittentheke
Copy link
Contributor Author

This is not stale.

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Jan 10, 2022
@frittentheke
Copy link
Contributor Author

@pstibrany @cyriltovena could you maybe take a peek into this issue?

@stale
Copy link

stale bot commented Mar 2, 2022

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely
    to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Mar 2, 2022
@frittentheke
Copy link
Contributor Author

@pstibrany @cyriltovena could you maybe take a peek into this issue?

this is not stale

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Mar 2, 2022
@stale
Copy link

stale bot commented Apr 17, 2022

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely
    to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Apr 17, 2022
@frittentheke
Copy link
Contributor Author

this is not stale

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Apr 19, 2022
@frittentheke
Copy link
Contributor Author

Apparently this is not broken anymore for 2.6.1:

loki, version 2.6.1 (branch: HEAD, revision: 6bd05c9a4)
  build user:       root@af90ed01061f
  build date:       2022-07-18T08:41:09Z
  go version:       go1.17.6
  platform:         linux/amd64
promtail, version 2.6.1 (branch: HEAD, revision: 6bd05c9a4)
  build user:       root@af90ed01061f
  build date:       2022-07-18T08:41:09Z
  go version:       go1.17.6
  platform:         linux/amd64

Also the promtail_build_info and loki_build_info metrics are back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant