Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 bucket prefix should be configurable #1760

Closed
Jiawei0227 opened this issue Feb 28, 2020 · 11 comments
Closed

S3 bucket prefix should be configurable #1760

Jiawei0227 opened this issue Feb 28, 2020 · 11 comments
Labels
stale A stale issue or PR that will automatically be closed.

Comments

@Jiawei0227
Copy link

Jiawei0227 commented Feb 28, 2020

It seems we only support the pointing bucket name in S3. However, we need should also support custom prefix of where the chunks go into the S3 bucket.

Right now they are all under "fake", which is unpleasant.

@slim-bean
Copy link
Collaborator

fake is the tenant ID, when running Loki in a multi-tenant configuration this is replaced by a unique tenant id. When auth is disabled it defaults to fake.

Is there a use case you have for a custom prefix or do you just not like the word 'fake'?

@Jiawei0227
Copy link
Author

Yes, I do have a use case for a custom prefix... It would be good if we can define a root prefix to place the fake/ or the multi-tenant id. We can make it default to "". What do you think?

@Jiawei0227
Copy link
Author

Hey, any updates on this? If someone can point me where this is configured I can help to make the change.

@cyriltovena
Copy link
Contributor

That's more a cortex discussion since we are using cortex for storing logs see https://github.com/cortexproject/cortex if that get accepted there then it will be added here too.

@stale
Copy link

stale bot commented Apr 29, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Apr 29, 2020
@stale stale bot closed this as completed May 6, 2020
@vprus
Copy link

vprus commented Jul 6, 2021

I think it's strange that I can specify bucket, but not prefix. Basically no other tools works this way. For specific example, I want logs to be put into "company-name-logs" bucket, and Loki to write to "company-name-logs/loki" specifically. The reason is that it's easier to keep track of all logs, and add some S3 lifecycle rules, if all logs are in the same bucket.

@alysonfranklin
Copy link

I'm still having the same problem.
Is there already a solution for this case?

I would like to use another Loki to send files to the same bucket, and I can't because of this problem.

@LinTechSo
Copy link
Contributor

Hi, same issue, any updates? @vprus @alysonfranklin @Jiawei0227

@Jiawei0227
Copy link
Author

/reopen

@Jiawei0227
Copy link
Author

unfortunately I dont know much about loki code so we will need Loki team to help here

@darintay
Copy link

darintay commented Aug 2, 2022

I raised an issue on the Cortex side, but no response, and it's not clear to me how active that project is now post-Mimir fork.

Another similar issue here - #5889 - that maybe has someone looking at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale A stale issue or PR that will automatically be closed.
Projects
None yet
Development

No branches or pull requests

7 participants