Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release "store objects under prefix object storage" feature #12364

Closed
tculp opened this issue Mar 26, 2024 · 7 comments
Closed

Release "store objects under prefix object storage" feature #12364

tculp opened this issue Mar 26, 2024 · 7 comments

Comments

@tculp
Copy link

tculp commented Mar 26, 2024

The feature proposed in #5889 and merged in #10096 has not yet been included in a release, documented, or included in the Loki helm charts.

Could this feature please be released or expectations set on when it may be released? It has been 5 months since the feature has been merged and the issue has been marked as completed, and despite multiple requests in the original issue for more information a update has not been given.

@JStickler
Copy link
Contributor

@tculp #10096 should be included in Loki 3.0, which is due to release by mid-April.

@tculp
Copy link
Author

tculp commented Apr 2, 2024

Thanks for the update!

@JStickler
Copy link
Contributor

@tculp Can we close this issue? Or do you want to wait until the release is officially out?

@tculp
Copy link
Author

tculp commented Apr 3, 2024

I'm tempted to wait until the release is officially out

@simonfelding
Copy link

Until then, you can use the CLI flag -store.object-prefix

@JStickler
Copy link
Contributor

@tculp Loki 3.0 has been released, and the CHANGELOG has been updated and indicates that #10096 is included in the release. (Release Notes are still being updated, our new automated release process only captured the most recent changes in the changelog so I've got to make some manual updates...)

@tculp
Copy link
Author

tculp commented Apr 10, 2024

Yeah, I actually have loki deployed with object_prefix set and it's working. Documentation in the helm chart would be nice, but I think this ticket would be considered done.

So other people can find it, here's the value that works:

loki:
  storage_config:
    object_prefix: loki-logs

@tculp tculp closed this as completed Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants