Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add liveness and readiness probes #234

Open
yorugac opened this issue May 17, 2023 · 1 comment
Open

Add liveness and readiness probes #234

yorugac opened this issue May 17, 2023 · 1 comment
Labels
enhancement New feature or request PLZ

Comments

@yorugac
Copy link
Collaborator

yorugac commented May 17, 2023

The operator currently doesn't define liveness and readiness probes. Apparently, they were added as a default in v1.3.0 of operator-sdk with a sample code:

	if err := mgr.AddHealthzCheck("healthz", healthz.Ping); err != nil {
		setupLog.Error(err, "unable to set up health check")
		os.Exit(1)
	}
	if err := mgr.AddReadyzCheck("readyz", healthz.Ping); err != nil {
		setupLog.Error(err, "unable to set up ready check")
		os.Exit(1)
	}

Confirm this behavior and add it to the operator.

@yorugac yorugac added enhancement New feature or request PLZ labels May 17, 2023
@yorugac
Copy link
Collaborator Author

yorugac commented May 17, 2023

Related issue: #235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PLZ
Projects
None yet
Development

No branches or pull requests

1 participant