Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphite: Query builder elements are misaligned #87657

Closed
NWRichmond opened this issue May 10, 2024 · 0 comments · Fixed by #87662
Closed

Graphite: Query builder elements are misaligned #87657

NWRichmond opened this issue May 10, 2024 · 0 comments · Fixed by #87662
Assignees
Labels
datasource/Graphite internal for issues made by grafanistas

Comments

@NWRichmond
Copy link
Contributor

NWRichmond commented May 10, 2024

Problem description

In the Graphite data source's query builder, the elements in each row are vertically misaligned, which is visually irritating:

demo graphite query builder row misalignment

Likely source

Although this can be patched by adding align-items: start to the InlineFieldRow's styles, this shouldn't be necessary. We don't see this happening in other places that InlineFieldRow exists, such as the InfluxDB data source's components/editor/query/influxql/visual/VisualInfluxQLEditor.tsx:

demo correct vertical alignment in inlinefieldrow in InfluxDB influxql editor

, which suggests that @grafana/ui's InlineFieldRow is working as expected, and this issue is the result of implementation details in the Graphite data source. For example, there appear to be some issues with the markup and possibly issues with local styles.

@NWRichmond NWRichmond added the internal for issues made by grafanistas label May 10, 2024
@NWRichmond NWRichmond self-assigned this May 10, 2024
@NWRichmond NWRichmond changed the title Graphite: Query builder's child elements are misaligned Graphite: Query builder elements are misaligned May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasource/Graphite internal for issues made by grafanistas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant