Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres: in the datasource-plugin, switch from lib/pq to pgx #79671

Closed
gabor opened this issue Dec 19, 2023 · 1 comment · Fixed by #81353 or #83768
Closed

postgres: in the datasource-plugin, switch from lib/pq to pgx #79671

gabor opened this issue Dec 19, 2023 · 1 comment · Fixed by #81353 or #83768
Assignees
Labels
datasource/Postgres internal for issues made by grafanistas

Comments

@gabor
Copy link
Contributor

gabor commented Dec 19, 2023

the current version of lib/pq has problems ( see #65816, caused by a bug in lib/pq at lib/pq#1106 ), and the project itself is in maintenance mode, meaning there's little chance that this gets fixed. the project itself recommends migration to https://github.com/jackc/pgx , so this is what we will do.

we did some initial tests, and the pgx works fine, with some minor issues, that we can fix in our code.
(NOTE: the lib/pq module is also used by grafana-backend, but this issue only deals with switching to pgx in the postgres datasource plugin.)

@gabor
Copy link
Contributor Author

gabor commented Mar 1, 2024

we had to revert the fix ( #83760 ) , we found certain complications, will have to adjust the code and merge it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasource/Postgres internal for issues made by grafanistas
Projects
Status: Complete
1 participant