Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve building of nested plugins #980

Open
tolzhabayev opened this issue May 7, 2024 · 0 comments
Open

Improve building of nested plugins #980

tolzhabayev opened this issue May 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@tolzhabayev
Copy link
Contributor

What would you like to be added:
Currently nested plugins are built by default in the main dist folder which forces developers to use relative paths in their executable properties. (Example)

If the relative path is changed to a non-relative one mage fails with:
Error: datasource should reference executable in root folder (source)

We should improve the build script so that it can also build executables in sub-folders without a need to put everything into the root folder and use relative paths.

Here is a workaround some developers are using: https://github.com/performancecopilot/grafana-pcp/blob/main/Makefile#L61-L69

Why is this needed:
The status quo causes issues with windows installations as they can not resolve the relative path properly.

@tolzhabayev tolzhabayev added the enhancement New feature or request label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 💡 Ideation
Development

No branches or pull requests

1 participant