Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getMacroMatches panics if given a macro arg string missing its close bracket #861

Open
njvrzm opened this issue Jan 18, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@njvrzm
Copy link
Contributor

njvrzm commented Jan 18, 2024

What happened:
getMacroMatches panics if given a query string that's missing the close bracket of an argument list, eg: select * from foo where $__timeTo(uhoh.

What you expected to happen:
An error should be returned instead and bubbled up from Interpolate.

How to reproduce it (as minimally and precisely as possible):
Remove the close parenthesis from any test in macros_test.go/TestInterpolate, like this one.

@njvrzm njvrzm added the bug Something isn't working label Jan 18, 2024
@njvrzm njvrzm self-assigned this Jan 18, 2024
njvrzm added a commit that referenced this issue Jan 18, 2024
This addresses #859
and #861 and
removes some duplicated logic.
njvrzm added a commit that referenced this issue Jan 18, 2024
This addresses #859
and #861 and
removes some duplicated logic.
njvrzm added a commit that referenced this issue Jan 18, 2024
This addresses #859
and #861 and
removes some duplicated logic.
njvrzm added a commit that referenced this issue Jan 22, 2024
This addresses #859
and #861 and
removes some duplicated logic.
njvrzm added a commit that referenced this issue Jan 22, 2024
This addresses #859 and #861 and removes some duplicated logic.
@academo
Copy link
Member

academo commented Feb 28, 2024

@njvrzm can you confirm if this issue is closed by the commits you pushed mentioning this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants