Fix error handling in CheckGoldenJSONResponse #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddtreece
requested review from
wbrowne and
marefr
and removed request for
a team
toddtreece
commented
Dec 14, 2022
| @@ -209,13 +210,17 @@ func CheckGoldenJSONResponse(t *testing.T, dir string, name string, dr *backend. | |||
| fpath := path.Join(dir, name+".jsonc") | |||
|
|
|||
| expected, err := readGoldenJSONFile(fpath) | |||
| assert.NoError(t, err) | |||
| if err != nil { | |||
There was a problem hiding this comment.
@ryantxu this was causing issues for me when new tests were added. it would fail and there was no way to create the file
wbrowne
reviewed
Dec 14, 2022
| require.NoError(t, err) | ||
| return | ||
| } | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
Maybe require.Fail would make the most sense to use here IE
require.Fail(t, "Error reading golden JSON file")
ryantxu
approved these changes
Dec 14, 2022
wbrowne
approved these changes
Dec 14, 2022
ryantxu
reviewed
Dec 14, 2022
| @@ -36,5 +36,5 @@ Dimensions: 1 Fields by 3 Rows | |||
|
|
|||
|
|
|||
| ====== TEST DATA RESPONSE (arrow base64) ====== | |||
| FRAME=QVJST1cxAAD/////mAEAABAAAAAAAAoADgAMAAsABAAKAAAAFAAAAAAAAAEDAAoADAAAAAgABAAKAAAACAAAAJwAAAADAAAAVAAAACgAAAAEAAAADP///wgAAAAMAAAAAAAAAAAAAAAFAAAAcmVmSWQAAAAs////CAAAABQAAAAJAAAARnJhbWUgT25lAAAABAAAAG5hbWUAAAAAVP///wgAAAAsAAAAIAAAAHsiY3VzdG9tIjp7InNvbWVWYWx1ZSI6InZhbHVlIn19AAAAAAQAAABtZXRhAAAAAAEAAAAYAAAAAAASABgAFAAAABMADAAAAAgABAASAAAAFAAAAIAAAACIAAAAAAAAA4gAAAACAAAAPAAAAAQAAADU////CAAAABgAAAAOAAAAU2luZ2xlIGZsb2F0NjQAAAQAAABuYW1lAAAAAAgADAAIAAQACAAAAAgAAAAcAAAAEgAAAHsidW5pdCI6IlBlcmNlbnQifQAABgAAAGNvbmZpZwAAAAAAAAAABgAIAAYABgAAAAAAAgAOAAAAU2luZ2xlIGZsb2F0NjQAAP////+IAAAAFAAAAAAAAAAMABYAFAATAAwABAAMAAAAKAAAAAAAAAAUAAAAAAAAAwMACgAYAAwACAAEAAoAAAAUAAAAOAAAAAUAAAAAAAAAAAAAAAIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAoAAAAAAAAAAAAAAABAAAABQAAAAAAAAAAAAAAAAAAAIXrUbgehSBAZmZmZmZmIUCkcD0K16MtQKRwPQrXIyRACtejcD0KIUAQAAAADAAUABIADAAIAAQADAAAABAAAAAsAAAAPAAAAAAAAwABAAAAqAEAAAAAAACQAAAAAAAAACgAAAAAAAAAAAAAAAAAAAAAAAAAAAAKAAwAAAAIAAQACgAAAAgAAACcAAAAAwAAAFQAAAAoAAAABAAAAAz///8IAAAADAAAAAAAAAAAAAAABQAAAHJlZklkAAAALP///wgAAAAUAAAACQAAAEZyYW1lIE9uZQAAAAQAAABuYW1lAAAAAFT///8IAAAALAAAACAAAAB7ImN1c3RvbSI6eyJzb21lVmFsdWUiOiJ2YWx1ZSJ9fQAAAAAEAAAAbWV0YQAAAAABAAAAGAAAAAAAEgAYABQAAAATAAwAAAAIAAQAEgAAABQAAACAAAAAiAAAAAAAAAOIAAAAAgAAADwAAAAEAAAA1P///wgAAAAYAAAADgAAAFNpbmdsZSBmbG9hdDY0AAAEAAAAbmFtZQAAAAAIAAwACAAEAAgAAAAIAAAAHAAAABIAAAB7InVuaXQiOiJQZXJjZW50In0AAAYAAABjb25maWcAAAAAAAAAAAYACAAGAAYAAAAAAAIADgAAAFNpbmdsZSBmbG9hdDY0AADIAQAAQVJST1cx | |||
| FRAME=QVJST1cxAAD/////gAEAABAAAAAAAAoADgAMAAsABAAKAAAAFAAAAAAAAAEDAAoADAAAAAgABAAKAAAACAAAAFgAAAACAAAAKAAAAAQAAAAg////CAAAAAwAAAAAAAAAAAAAAAUAAAByZWZJZAAAAED///8IAAAAFAAAAAkAAABGcmFtZSBUd28AAAAEAAAAbmFtZQAAAAABAAAAGAAAAAAAEgAYABQAAAATAAwAAAAIAAQAEgAAABQAAACwAAAAtAAAAAAAAAWwAAAAAwAAAGgAAAA0AAAABAAAAKz///8IAAAAGAAAAA0AAABzaW5nbGUgc3RyaW5nAAAABAAAAG5hbWUAAAAA2P///wgAAAAUAAAACQAAAHsiYSI6ImIifQAAAAYAAABsYWJlbHMAAAgADAAIAAQACAAAAAgAAAAgAAAAFQAAAHsiZGlzcGxheU5hbWUiOiIxMjMifQAAAAYAAABjb25maWcAAAAAAAAEAAQABAAAAA0AAABzaW5nbGUgc3RyaW5nAAAAAAAAAP////+YAAAAFAAAAAAAAAAMABYAFAATAAwABAAMAAAAGAAAAAAAAAAUAAAAAAAAAwMACgAYAAwACAAEAAoAAAAUAAAASAAAAAMAAAAAAAAAAAAAAAMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAAAAAABAAAAAAAAAACAAAAAAAAAAAAAAAAQAAAAMAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAIAAAADAAAAYWJjAAAAAAAQAAAADAAUABIADAAIAAQADAAAABAAAAAsAAAAOAAAAAAAAwABAAAAkAEAAAAAAACgAAAAAAAAABgAAAAAAAAAAAAAAAAAAAAAAAoADAAAAAgABAAKAAAACAAAAFgAAAACAAAAKAAAAAQAAAAg////CAAAAAwAAAAAAAAAAAAAAAUAAAByZWZJZAAAAED///8IAAAAFAAAAAkAAABGcmFtZSBUd28AAAAEAAAAbmFtZQAAAAABAAAAGAAAAAAAEgAYABQAAAATAAwAAAAIAAQAEgAAABQAAACwAAAAtAAAAAAAAAWwAAAAAwAAAGgAAAA0AAAABAAAAKz///8IAAAAGAAAAA0AAABzaW5nbGUgc3RyaW5nAAAABAAAAG5hbWUAAAAA2P///wgAAAAUAAAACQAAAHsiYSI6ImIifQAAAAYAAABsYWJlbHMAAAgADAAIAAQACAAAAAgAAAAgAAAAFQAAAHsiZGlzcGxheU5hbWUiOiIxMjMifQAAAAYAAABjb25maWcAAAAAAAAEAAQABAAAAA0AAABzaW5nbGUgc3RyaW5nAAAAqAEAAEFSUk9XMQ== | |||
| FRAME=QVJST1cxAAD/////kAEAABAAAAAAAAoADgAMAAsABAAKAAAAFAAAAAAAAAEEAAoADAAAAAgABAAKAAAACAAAAJwAAAADAAAAVAAAACgAAAAEAAAAFP///wgAAAAMAAAAAAAAAAAAAAAFAAAAcmVmSWQAAAA0////CAAAABQAAAAJAAAARnJhbWUgT25lAAAABAAAAG5hbWUAAAAAXP///wgAAAAsAAAAIAAAAHsiY3VzdG9tIjp7InNvbWVWYWx1ZSI6InZhbHVlIn19AAAAAAQAAABtZXRhAAAAAAEAAAAYAAAAAAASABgAFAAAABMADAAAAAgABAASAAAAFAAAAHgAAACAAAAAAAAAA4AAAAACAAAANAAAAAQAAADc////CAAAABAAAAAGAAAAbnVtYmVyAAAGAAAAdHN0eXBlAAAIAAwACAAEAAgAAAAIAAAAHAAAABIAAAB7InVuaXQiOiJQZXJjZW50In0AAAYAAABjb25maWcAAAAAAAAAAAYACAAGAAYAAAAAAAIADgAAAFNpbmdsZSBmbG9hdDY0AAD/////iAAAABQAAAAAAAAADAAWABQAEwAMAAQADAAAACgAAAAAAAAAFAAAAAAAAAMEAAoAGAAMAAgABAAKAAAAFAAAADgAAAAFAAAAAAAAAAAAAAACAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAKAAAAAAAAAAAAAAAAQAAAAUAAAAAAAAAAAAAAAAAAACF61G4HoUgQGZmZmZmZiFApHA9CtejLUCkcD0K1yMkQArXo3A9CiFAEAAAAAwAFAASAAwACAAEAAwAAAAQAAAALAAAADwAAAAAAAQAAQAAAKABAAAAAAAAkAAAAAAAAAAoAAAAAAAAAAAAAAAAAAAAAAAAAAAACgAMAAAACAAEAAoAAAAIAAAAnAAAAAMAAABUAAAAKAAAAAQAAAAU////CAAAAAwAAAAAAAAAAAAAAAUAAAByZWZJZAAAADT///8IAAAAFAAAAAkAAABGcmFtZSBPbmUAAAAEAAAAbmFtZQAAAABc////CAAAACwAAAAgAAAAeyJjdXN0b20iOnsic29tZVZhbHVlIjoidmFsdWUifX0AAAAABAAAAG1ldGEAAAAAAQAAABgAAAAAABIAGAAUAAAAEwAMAAAACAAEABIAAAAUAAAAeAAAAIAAAAAAAAADgAAAAAIAAAA0AAAABAAAANz///8IAAAAEAAAAAYAAABudW1iZXIAAAYAAAB0c3R5cGUAAAgADAAIAAQACAAAAAgAAAAcAAAAEgAAAHsidW5pdCI6IlBlcmNlbnQifQAABgAAAGNvbmZpZwAAAAAAAAAABgAIAAYABgAAAAAAAgAOAAAAU2luZ2xlIGZsb2F0NjQAAMABAABBUlJPVzE= | |||
There was a problem hiding this comment.
These are here because of #580
This is not required since the match is still valid, but seems better to have this in sync with what would be produced today
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes an issue from #571 that prevents golden files from being created.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: