Adding With in logger to keep logging key/value pairs
#578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferruvich
added
enhancement
ferruvich
requested review from
wbrowne and
marefr
and removed request for
a team
|
|
thepalbi
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, the
logpackage contains a very simple logger.A common pattern in loggers is to re-use fields between logging statements, by creating "sub-loggers" that retain and always include wanted key/value pairs.
A way to achieve this would be to create a new function, called With, with the following signature
and use
github.com/hashicorp/go-hclogLogger.Withto build and return this new sub-logger.Which issue(s) this PR fixes:
Fixes #577