Dataplane: Spec - Update NoData to allow for no frames #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebrandt
added
documentation
kylebrandt
requested review from
yesoreyeram,
toddtreece,
ryantxu and
grobinson-grafana
kylebrandt
requested review from
wbrowne and
marefr
and removed request for
a team
toddtreece
approved these changes
Nov 22, 2022
grobinson-grafana
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stating the no frames (e.g.
"A": Frames: []) is valid for "NoData", but the single frame form is preferable in most cases.Adding this because I think it is likely what a fair amount of datasources already do, and if there is no metadata to add then nothing is added by adding the frame.
But open to arguments against since this adds more variation for readers.