From b4c4d4a4951e282a14d8b8ce1300f3c5d212b48e Mon Sep 17 00:00:00 2001 From: gitgaoxiang Date: Mon, 9 May 2022 09:27:04 +0800 Subject: [PATCH] Update grafananotificationchannel_controller.go Fix: [Bug] GrafanaNotificationChannel cr not have UID will cause the program to crash #747 --- .../grafananotificationchannel_controller.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/controllers/grafananotificationchannel/grafananotificationchannel_controller.go b/controllers/grafananotificationchannel/grafananotificationchannel_controller.go index 3e958b97b..4a2bd8c54 100644 --- a/controllers/grafananotificationchannel/grafananotificationchannel_controller.go +++ b/controllers/grafananotificationchannel/grafananotificationchannel_controller.go @@ -276,7 +276,10 @@ func (r *GrafanaNotificationChannelReconciler) reconcileNotificationChannels(req if err := json.Unmarshal(processed, &rawJson); err != nil { return reconcile.Result{}, err } - + if rawJson.UID == nil { + r.Log.Info(fmt.Sprintf("cannot process notificationchannel %v/%v, UID is nil", notificationchannel.Namespace, notificationchannel.Name)) + return reconcile.Result{}, nil + } if _, err = client.GetNotificationChannel(*rawJson.UID); err != nil { status, err = client.CreateNotificationChannel(processed) } else {