Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana Dashboard CR not working when enabed TLS in grafana #785

Closed
anushanagireddy0430 opened this issue Jul 8, 2022 · 9 comments
Closed
Labels
bug Something isn't working needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@anushanagireddy0430
Copy link

Dashboard not getting created using CR "GrafanaDashboard" when grafana runs on https.
All the other CR's working perfectly when grafana runs on https.

Example: When we try to deploy a sample service with grafana dashboard CR packaged into the helmchart of the sample service, dashboards of the sample service are not getting created automatically in grafana.
The label used in GrafanaDashboard CR is correct and we have used --scan-all option to read dashboards CR's deployed cluster wide.

We have deployed grafana operator v4.4.1 and grafana v9.0.2.

Steps to reproduce the behavior:

  1. Images used are "grafana/grafana-enterprise:9.0.2" and "quay.io/grafana-operator/grafana-operator:v4.4.1"
  2. Deploy grafana operator,crd's, grafana, grafana datasource and grafana dashboard cr's in single helm deployment.
  3. Added config related to tls as mentiond in pull request "feat: Add support for API served via HTTPS when preferService: true #772"
  4. Grafana and operator pods came to running state
  5. Able to launch and authenticate to grafana on https but dashboards are not created
  6. I can see below error when described the grafana dashboard CR

image
and grafana is throwing below error
image

Expected behavior
Dashboard of a service should be created automatically in grafana when grafanadashboard CR is deployed when TLS is enabled in grafana and deployed through operator.

Suspect component/Location where the bug might be occuring
This issue is occuring only when tls enabled in grafana

Runtime (please complete the following information):

  • OS: rhel 7.7
  • Grafana Operator Version 4.4.1
  • Environment: kubernetes v1.21
  • Deployment type: operator

Tested same scenarion with grafana version 8.5.0 . Getting same "tls handshake error"

Could you please prioritize this issue and help us out as this is the major security blocker for our usecase.

@anushanagireddy0430 anushanagireddy0430 added bug Something isn't working needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 8, 2022
@weisdd
Copy link
Collaborator

weisdd commented Jul 9, 2022

Probably related to #642, which got fixed in: #772. It's not included in any release yet, so you can either wait for project maintainers to create one or just build an image yourself from the master branch.

@anushanagireddy0430
Copy link
Author

anushanagireddy0430 commented Jul 11, 2022

Hi,
I have cloned it and tried to build. Getting below error.
image
After removing --platform option in dockerfile, I am able to build successfully.
But I want know when the changes will be oficially releasing and in which version we can expect.

@HVBE
Copy link
Collaborator

HVBE commented Jul 11, 2022

@pb82 @NissesSenap Should we think about a release soon? ^^

@anushanagireddy0430
Copy link
Author

Hi Stefanski

Thanks for the update. I want to let you know that,
We need this feature and it would be good if you could release this feature asap. Please let us know when we can expect the release, so that we can plan our usecases accordingly.

@pb82
Copy link
Collaborator

pb82 commented Jul 12, 2022

@HubertStefanski @NissesSenap we have a fair number of bugfixes and features since the last release. So we're in a good spot to create a new one.

@NissesSenap
Copy link
Collaborator

We will discuss a release during today's meeting. But since this is already solved I will close this issue.

@anushanagireddy0430
Copy link
Author

Thanks @HubertStefanski @NissesSenap for quick responses.
I will start using v4.5.0

@anushanagireddy0430
Copy link
Author

Hi Team
I want to know which version of grafana can be used with operator v4.5.0
We are using "baseImage" option to provide a custom grafana image(grafana/grafana:).

To be fully compatible with operator v4.5.0 which version of grafana we should use?

@weisdd
Copy link
Collaborator

weisdd commented Jul 13, 2022

https://github.com/grafana-operator/grafana-operator/blob/9c54a394e6df53408b3aa3b543dc1fd78fa7d373/controllers/constants/constants.go#L5 - that's the default version operator uses.

I think the operator is likely to have support for some fields which got introduced in newer versions of grafana. I normally use the latest version. In the end, it's all about building your own lab to test if it all works just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

5 participants