Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Openshift Route using passthrough doesn't work #766

Closed
m1schka opened this issue May 27, 2022 · 2 comments
Closed

[Bug] Openshift Route using passthrough doesn't work #766

m1schka opened this issue May 27, 2022 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@m1schka
Copy link

m1schka commented May 27, 2022

Describe the bug
In case of using the ingress/route on openshift with the passthrough mechanism, the route cannot get created, because the path is always set here

Version
v4.4.1

To Reproduce
using a grafana like this:

  ingress:
    enabled: true
    # tlsEnabled: true
    # tlsSecretName: project-ingress-cert
    targetPort: grafana-proxy
    # let the service handle the tls secret because the operator doesn't embed a tls secret into the route object
    termination: passthrough
  service:
    annotations:
      service.alpha.openshift.io/serving-cert-secret-name: project-ingress-cert

resulting in:

message: >-
    Route.route.openshift.io "grafana-route" is invalid: spec.path: Invalid
    value: "/": passthrough termination does not support paths
  phase: failing

Expected behavior
expect the route to get created/updated properly

Suspect component/Location where the bug might be occuring
here needs to be a check whether the termination is passthrough, then allow an empty path

Additional context
We use this workaround, because the ingress spec tls variables are ignored when creating a route object. We wouldn't need it if the operator would get the referenced secret from tlsSecretName and embedd it into the route object. (you can create a feature request out of this, if you like)

@m1schka m1schka added bug Something isn't working needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 27, 2022
@NissesSenap NissesSenap added help wanted Extra attention is needed triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 30, 2022
@NissesSenap
Copy link
Collaborator

Yeah sadly this sounds reasonable. @m1schka are you willing/able to create a PR to solve this issue?

@HubertStefanski
Copy link
Collaborator

@m1schka Can you verify that this is resolved through #773, feel free to reopen this if it still isn't resolved, thanks :thumbs4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants